check for primary script before redirect #18572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @tanyaparker |
Bjvanminnen
approved these changes
Oct 23, 2017
|
User bad is 5xx error if you have a newly assigned course or script, but no progress in any courses/scripts. It wants to redirect you to the primary script overview page, but can't because it doesn't know what the id of the primary script is. It's been tricky to repro exactly because it only seems to affect some courses/scripts. |
|
5xx error describes what happens on our end - it would be good to also know what the user sees when they run into this error. I suspect we would have received zendesk tickets if this was too painful an experience, so I will operate under the assumption that shipping this as part of the regular DTP is okay until/unless I hear otherwise. |
tanyaparker
approved these changes
Oct 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced a bug in #18493. This change confirms that the user does have a primary script before trying to redirect them to their primary script's course overview page.