run all shared tests #18640
Merged
run all shared tests #18640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 thanks for fixing |
|
Got a green test run. Gonna rerun a couple more times to make sure we still dont have any intermittency issues. |
|
Disabled another test, and got a green run. Going to look for 3x green runs before I merge. |
|
Got a second green run (failing runs in between were SauceLabs issues). Trying for three 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default pattern for
rake testis to only run against files in the test directory. It does not recurse into subdirectories, so we had a bunch of middleware tests that were not running. Thankfully, they appear to all still pass.