Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound library updates #18668

Merged
merged 2 commits into from Oct 27, 2017
Merged

Sound library updates #18668

merged 2 commits into from Oct 27, 2017

Conversation

caleybrock
Copy link
Contributor

@caleybrock caleybrock commented Oct 26, 2017

Should start in the sound library tab.
When no sounds are found, update the text.
screen shot 2017-10-26 at 12 57 13 pm
Note: the sound library is currently not localized, so I'm keeping it that way.
This affects app lab and game lab.

Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM!

Do you think it also makes sense to reverse the order of the Sound Library and My Files tabs?

@caleybrock
Copy link
Contributor Author

Poorva brought up a good point that the "My Files" tab is also first in the icon library and we want it to match. So leaving as is for now.

@caleybrock caleybrock merged commit e0c3119 into staging Oct 27, 2017
@caleybrock caleybrock deleted the sound-library branch October 27, 2017 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants