Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use stubs instead of hardcoding ids in unit test #18701

Merged
merged 2 commits into from Oct 27, 2017
Merged

Use stubs instead of hardcoding ids in unit test #18701

merged 2 commits into from Oct 27, 2017

Conversation

balderdash
Copy link
Contributor

No description provided.

@balderdash balderdash requested a review from aoby October 27, 2017 21:05
aoby
aoby approved these changes Oct 27, 2017
View reviewed changes
Copy link
Contributor

@aoby aoby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@balderdash balderdash merged commit 72486f5 into staging Oct 27, 2017
@balderdash balderdash deleted the hardcoded-id branch October 31, 2017 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoby aoby aoby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@balderdash @aoby