Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a story for the setup step #18732

Merged
merged 2 commits into from Oct 30, 2017
Merged

Added a story for the setup step #18732

merged 2 commits into from Oct 30, 2017

Conversation

epeach
Copy link

@epeach epeach commented Oct 30, 2017

Adding a story with the different styles for the setup step.

screenshot from 2017-10-30 11-11-10

screenshot from 2017-10-30 11-11-21

story: () => (
<SetupStep
stepName="This step is successful"
stepStatus="SUCCEEDED"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These status constants are already exported from SetupStep.jsx - let's import and use them here.

export const HIDDEN = 'HIDDEN';
export const WAITING = 'WAITING';
export const ATTEMPTING = 'ATTEMPTING';
export const SUCCEEDED = 'SUCCEEDED';
export const FAILED = 'FAILED';
export const CELEBRATING = 'CELEBRATING';

Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise great! 👍

@islemaster
Copy link
Contributor

👏

@epeach epeach merged commit 3bd522b into staging Oct 30, 2017
@epeach epeach deleted the setup-step-story branch November 3, 2017 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants