Maker: Fix browser detection #18734
Merged
Maker: Fix browser detection #18734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unfortunate typo was quietly causing us to skip our supported browser check when using Maker Toolkit in App Lab. The bug was introduced in v2017-10-13.0. The browser check on the setup page was still working, because it's handled separately here.
Verified successful connection in Chrome with extension and Maker Toolkit browser, and correct error message on Firefox.
Before
When running with Maker Toolkit on Firefox:
After
When running with Maker Toolkit on Firefox:
