Fix Game Lab group collisions #18751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not familiar with this code, but it looks good to me! |
islemaster
approved these changes
Oct 30, 2017
There was a problem hiding this comment.
Great work tracking this down! As discussed offline, agree that this should get merged as-is and investigate testing a bit later. Possibly using level tests to check this behavior with the real interpreter since our GameLabGroup tests don't use the interpreter - would be a good challenge to pair with @epeach on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example code: https://studio.code.org/projects/gamelab/_oLwG6JeyexRRnAI4QjI3anERbKmRTK5Q5WwfgAM4MU
Before:
After:
We got a couple of tickets around group collisions, but we're sure how long it has been broken for. We also have a full suite of tests around GameLabGroup collisions, but since they try to mimic the interpreter instead of use it directly, they were passing even though the same code copied into GameLab was failing.
I found a commit from @pcardune in June called "Fix gamelab interpreter shenanigans to make sprite collisions work again" and noticed that the variable replaced in this file was not replaced in GameLab group. I am not sure how to test this since it's related to interpreter work, but I'm open to suggestions @pcardune
I propose merging this now since students/teachers are looking for a fix, and figure out how to test interpreter/Game Lab better when Paul can help.