Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show feedback dialog again after publish #18886

Merged
merged 4 commits into from
Nov 5, 2017

Conversation

davidsbailey
Copy link
Member

Work item description from bug bash doc:

Let’s open up the Finish dialog again once user is done with the publish dialog when in a level

before

the feedback dialog does not open again after publishing.

after

the feedback dialog opens again after publishing, with Save and Publish grayed out:

show-feedback-dialog-after-publish

@davidsbailey
Copy link
Member Author

Tacking on another work item to this PR since both are relatively simple. From the same doc:

  • Clicking “Save” and then “Publish” without ever closing the Finish dialog puts the same project into my projects list twice
    • Ideally, we can update the “Publish” and “Save” button in this case to disabled “Published” and “Saved” buttons.

We don't want to say "Published", since the project isn't published, so instead I'm making be disabled but still say "Publish".

"after" screenshot

screen shot 2017-11-03 at 11 20 35 am

@davidsbailey davidsbailey merged commit 9211f5c into staging Nov 5, 2017
@davidsbailey davidsbailey deleted the show-feedback-after-publish branch November 5, 2017 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants