Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract VideoThumbnail component from HelpTabContents #19002

Merged
merged 2 commits into from Nov 8, 2017

Conversation

joshlory
Copy link
Contributor

@joshlory joshlory commented Nov 8, 2017

Extract component for re-use in CSF hints. The only functional difference is that the cursor is now a pointer instead of the default.

image

Copy link

@epeach epeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

import React from 'react';
import VideoThumbnail from './VideoThumbnail';


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Extra line?

@joshlory joshlory merged commit 100901b into staging Nov 8, 2017
@joshlory joshlory deleted the extract-video-thumbnail-component branch November 8, 2017 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants