DTL (Test > Levelbuilder): c8ab8459 #19143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The situation as it stands: - The TopInstructionsCSF component is not designed to work with embedded levels, and is set up to be visually hidden when in an embedded level - The TopInstructionsCSP component is set up to work just fine with embedded levels - The expectation is that level types themselves are given the final word on which instructions component they use, and are in general trusted to handle all configuration customization themselves. In order for markdown instructions on embedded levels to work nicely, we want to situationally use the CSP instructions component for embedded levels with markdown instructions, but because we trust the level types to make that decision alone this means adding that logic to each level type individually. Obviously this is about as non-DRY as you can get, but I'm not sure how best to balance sharing this logic with continuing to give the individual level types as much agency as possible. Thoughts?
…ign mode elements in code mode"" This reverts commit dc6f645.
I18n sync Down & Out 11/13
Sign up page: school info should be required for 1/3 of users
Use updated links from Poorva for Emergency Mode UI
Forward AWS Health events to Slack
Filter quick view table by status
…ment show StartNewProject widget based on a percent experiment
Update craft through code-dot-org/craft@ab5b5c6
Add "placeBlockDirection" to blocks.js
[Merge after Nov. 13] Remove MC landing page DCDO customization
There are several syntax errors in Khmer in crowdin right now. Undo the most recent crowdin sync for that locale to unbreak the build while we decide how to handle the data on crowdin.
DTS (Levelbuilder > Staging) [robo-dts]
undo Khmer changes to prevent build error
Maker: Standardize toggle switch events
Update MC share image with new asset from Joel (fix jagged edges)
…mg-url Tests: Ensure design mode image URL is protocol-relative
Update craft through code-dot-org/craft@97a9f9e
DTT (Staging > Test) [will]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.