Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add minecraft hero to 'start new project' widget #19146

Merged
merged 3 commits into from
Nov 15, 2017

Conversation

davidsbailey
Copy link
Member

before

screen shot 2017-11-14 at 10 27 49 am 1

after

screen shot 2017-11-14 at 4 01 30 pm

@caleybrock
Copy link
Contributor

This image has been approved then?

Will this project type be allowed to be selected in the script edit page on levelbuilder?

@caleybrock
Copy link
Contributor

This is probably a @poorvasingal or mark question, but the fact that the margins above and below the category names makes this list really hard to parse visually. I get that it takes up a lot of space, but I think it would be better to double the margin above the categories.

@davidsbailey
Copy link
Member Author

Thanks Caley, great questions.

yes, @ryansloan has gotten approval for this image.

No, I have overlooked levelbuilder yet again. Thanks for catching this! I've fixed it now.

I'll wait for PM/UX feedback before merging.

@@ -264,6 +264,7 @@ const ScriptEditor = React.createClass({
<option value="frozen">Frozen</option>
<option value="minecraft_adventurer">Minecraft Adventurer</option>
<option value="minecraft_designer">Minecraft Designer</option>
<option value="minecraft_hero">Minecraft Hero</option>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@caleybrock
Copy link
Contributor

I think it's fine to merge this and do the style fixing in a follow up PR - it's mostly unrelated to this.

@davidsbailey
Copy link
Member Author

OK, will do. @poorvasingal , we'd still love your input.

@davidsbailey
Copy link
Member Author

Here it is with double the margin between sections:
screen shot 2017-11-14 at 4 29 50 pm

@davidsbailey davidsbailey merged commit df137a3 into staging Nov 15, 2017
@davidsbailey davidsbailey deleted the start-minecraft-hero branch November 15, 2017 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants