-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add minecraft hero to 'start new project' widget #19146
Conversation
This image has been approved then? Will this project type be allowed to be selected in the script edit page on levelbuilder? |
This is probably a @poorvasingal or mark question, but the fact that the margins above and below the category names makes this list really hard to parse visually. I get that it takes up a lot of space, but I think it would be better to double the margin above the categories. |
Thanks Caley, great questions. yes, @ryansloan has gotten approval for this image. No, I have overlooked levelbuilder yet again. Thanks for catching this! I've fixed it now. I'll wait for PM/UX feedback before merging. |
@@ -264,6 +264,7 @@ const ScriptEditor = React.createClass({ | |||
<option value="frozen">Frozen</option> | |||
<option value="minecraft_adventurer">Minecraft Adventurer</option> | |||
<option value="minecraft_designer">Minecraft Designer</option> | |||
<option value="minecraft_hero">Minecraft Hero</option> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I think it's fine to merge this and do the style fixing in a follow up PR - it's mostly unrelated to this. |
OK, will do. @poorvasingal , we'd still love your input. |
before
after