Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use highest quality image when fetching youtube thumbnails #19148

Merged
merged 2 commits into from
Nov 20, 2017

Conversation

tanyaparker
Copy link
Contributor

@tanyaparker tanyaparker commented Nov 15, 2017

Before image
After image

Copy link
Member

@breville breville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should definitely keep an eye out for any side effects, but seems like a good upgrade.

Copy link
Contributor

@wjordan wjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me if we think the quality upgrade is worth the increase in file-size.

If so, would we want to update

results[dashboard_dir('public', 'c', 'video_thumbnails', "#{i[:id]}.jpg")] = "http://img.youtube.com/vi/#{i[:youtube_code]}/mqdefault.jpg"
as well?

@tanyaparker
Copy link
Contributor Author

I say let's try moving the pendulum a little more in the direction of better quality/bigger file size. I think this particular change is worth it. And as we keep tabs on performance, we can decide if we need to revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants