Maker: Remove "press" event from autocomplete #19153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the button "press" event from autocomplete (in text mode) and dropdowns (in block mode) for `onBoardEvent`, because it's [simply an alias for "down"][1] in the johnny-five library. This affects dropdowns when the selected component is buttonL or buttonR, or when it's unrecognized (in which case we display all possible event names). [1]: https://github.com/code-dot-org/johnny-five/blob/863e922f8170e670088d3dfe6132060293749ba5/lib/button.js#L11-L14
ewjordan
approved these changes
Nov 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the button "press" event from autocomplete (in text mode) and dropdowns (in block mode) for
onBoardEvent, because it's simply an alias for "down" in the johnny-five library. This affects dropdowns when the selected component is buttonL or buttonR, or when it's unrecognized (in which case we display all possible event names).This will not break existing projects - "press" is still a perfectly valid event name to pass through to the underlying library, it just won't be suggested by autocomplete anymore.