Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a simple i18n test for the new MC:Agent tutorial #19189

Merged
merged 1 commit into from Nov 16, 2017
Merged

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Nov 16, 2017

note that I expect this test to fail based on what's currently in staging: https://staging-studio.code.org/s/hero/stage/1/puzzle/2

A fix is in progress (by way of a crowdin sync), and this test is to make sure we don't do this again

@Hamms Hamms requested a review from joshlory November 16, 2017 00:40
Copy link

@jeremydstone jeremydstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hamms Hamms merged commit cbeb04e into staging Nov 16, 2017
@Hamms Hamms deleted the mc-agent-i18n-test branch November 16, 2017 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants