Scoring improvements #19190
Merged
Scoring improvements #19190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ( | ||
| <DetailViewResponse | ||
| question="Regional Partner" | ||
| questionId="regionalParnterName" |
There was a problem hiding this comment.
typo: should be "regionalPartnerName"
| able_to_attend_single: ['Yes', 'No'], | ||
| committed: ['Yes', 'No'], | ||
| regional_partner_name: YES_NO, | ||
| # Need to include whether the participant is new |
There was a problem hiding this comment.
Is this change coming in a separate PR/being tracked somewhere?
There was a problem hiding this comment.
Yeah - Andrew's PR
| @@ -1,5 +1,7 @@ | |||
| module Teacher1819ApplicationConstants | |||
| # Remove newlines and leading whitespace from multiline strings | |||
There was a problem hiding this comment.
This comment should be below your constant because it applies to self.clean_multiline
clareconstantine
approved these changes
Nov 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Score some more questions