React congrats certificate component #19196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a `/v2/certificate` alias for `/api/hour/certificate`. The /v2/* path is already proxied to Pegasus, see https://github.com/code-dot-org/code-dot-org/blob/0ea2718b5f33be7956db8942e62cbee298a77dd8/cookbooks/cdo-varnish/libraries/http_cache.rb#L170-L173.
|
|
Erin007
reviewed
Nov 16, 2017
| "congratsCertificatePersonalize": "Personalize your certificate", | ||
| "congratsCertificateShare": "Share your achievement", | ||
| "congratsCertificateThanks": "Thanks for submitting!", | ||
| "congratsCertificateContinue": "Now, keep going with our other courses, or see more options to Learn beyond an Hour below.", |
Erin007
reviewed
Nov 16, 2017
| @@ -11,31 +15,104 @@ const styles = { | |||
| image: { | |||
| width: '50%', | |||
| }, | |||
| personalize: { | |||
| width: '50%', | |||
| float: 'right', | |||
There was a problem hiding this comment.
Do we need to style for RTL too? Fine to save for later.
Erin007
approved these changes
Nov 16, 2017
# Conflicts: # apps/src/templates/Certificate.jsx # apps/src/templates/Congrats.jsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a number of fit & finish things to resolve:
get_random_donor_twittermention.