Move to the top of the form when transitioning from signup to census #19201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breville
reviewed
Nov 16, 2017
| @@ -170,6 +170,8 @@ function showCensusForm(data) { | |||
| $('#census-header').show(); | |||
| $('#thanks-header').show(); | |||
| $('#census-form').show(); | |||
| // Jump up to the top of the form | |||
| window.location.hash = '#thanks-header'; | |||
There was a problem hiding this comment.
We could also do a smooth scroll which often looks nice.
code-dot-org/shared/js/helpers.js
Line 4 in 7c0d72c
There was a problem hiding this comment.
I didn't know about that. I tried it out and I actually like the original approach better. The scroll doesn't really make sense here since we are swapping out one form for the other rather than moving to another spot in the same form.
|
Can you take a screencap with licecap or Jing? |
|
|
tanyaparker
approved these changes
Nov 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, after you hit "submit and continue" on the HoC signup form, you see the bottom of the census form which is a bit confusing. This repositions you to the top of the form.