Reenable MC i18n test #19219
Merged
Reenable MC i18n test #19219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous failures were due to either the `{currentPlayerName}` special
string or standard markdown formatting being present in the instructions
string. Fortunately, the very first level has neither of those.
Unfortunately, it looks like it is the only one that does; these
instructions are supposed to remain as they are, but if either
formatting feature gets introduced in the future we're going to need to
improve this test to deal with formatted strings. For now, though, this
is good enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous failures were due to either the
{currentPlayerName}specialstring or standard markdown formatting being present in the instructions
string. Fortunately, the very first level has neither of those.
Unfortunately, it looks like it is the only one that does; these
instructions are supposed to remain as they are, but if either
formatting feature gets introduced in the future we're going to need to
improve this test to deal with formatted strings. For now, though, this
is good enough.
Verified locally with
bundle exec ./runner.rb -c ChromeLatestWin7 --with-status-page -f features/i18n.feature --verbose