New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change "Parents" to "Parents and Students" on /yourschool #19223
Conversation
description={i18n.yourSchoolParentDesc()} | ||
buttonText={i18n.yourSchoolParentButton()} | ||
link={pegasus('/help')} | ||
isRtl={false} | ||
allowWrap={true} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼 parameter makes sense, thanks
@@ -11,6 +11,9 @@ const styles = { | |||
width: 310, | |||
background: color.teal | |||
}, | |||
card_allow_wrap: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these labels are usually camelcase, e.g cardAllowWrap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before and after screenshots, please.
whiteSpace: 'nowrap', | ||
textOverflow: 'ellipsis', | ||
overflow: 'hidden' | ||
}, | ||
titleAllowWrap: { | ||
lineHeight: '110%' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.1
should work here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
screenshots lgtm
This also ads an option to ResourceCard to allow the title to wrap.