More test coverage for hoc_canonicalized_i18n_path #19250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjordan
commented
Nov 17, 2017
| end | ||
| else | ||
| @country = hoc_detect_country | ||
| path = File.join([possible_country_or_company, possible_language, path].select {|i| !i.nil_or_empty?}) | ||
| path = File.join([possible_country_or_company, possible_language, path].reject(&:nil_or_empty?)) | ||
| end | ||
|
|
||
| country_language = HOC_COUNTRIES[@country]['default_language'] | ||
| @language = @user_language || country_language || hoc_detect_language |
There was a problem hiding this comment.
I'm pretty sure hoc_detect_language is unreachable because country_language should always be present- not confident enough in this to change/remove this code though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This old (legacy) pegasus route is still in use on our site, and has convoluted logic and low test coverage making it risky code to maintain. This PR increases the test coverage slightly to better document existing behavior and prevent regressions.
Still more work could be done to further fix up this legacy code, this is just an incremental step.