show 'Start new project' in Public Gallery #19265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
force-pushed
the
public-gallery-new-projects
branch
from
e2ca233
to
42bef05
Compare
islemaster
approved these changes
Nov 17, 2017
| <StartNewProject | ||
| isRtl={isRtl} | ||
| canViewFullList={true} | ||
| canViewAdvancedTools={true} |
There was a problem hiding this comment.
Nit: Prefer providing boolean literal props as flags
<StartNewProject
isRtl={isRtl}
canViewFullList
canViewAdvancedTools
/>(according to AirBnB's React/JSX styleguide, second rule in the Props section)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
the StarNewProject buttons were launched on the My Project page in #19242 . Some additional background can be found there.
Description
now that we've chosen which buttons we want to use to create more projects, we want to show them in more places, starting with the Public Gallery. Clicking Artist goes to a new artist project. For signed-out users, clicking App Lab goes to a sign-in page, which then goes to a new applab project.
Screenshots