Hourofcode redirect to original IP-address location #19272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redirect to location of (spoofable) source ip-address, rather than the (secure) location of the first untrusted proxy in the forwarded IP-address chain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to make the redirect logic on hourofcode.com more stable by ignoring intermediate/untrusted proxy-server IP addresses.
The original implementation of
hoc_detect_countryusedGeocoder.search(request.ip).first(equivalent torequest.safe_location), which usesRack::Request#ipto determine the source IP address.#iptries to determine a 'secure' (unspoofable) IP address using theREMOTE_ADDRorHTTP_X_FORWARDED_FORrequest header, backtracking through the forwarded-ip-address chain until it reaches the first address that's not 'trusted' IP-address range (either private range or in a trusted-ip whitelist, which for us includes a list of CloudFront IP-address ranges maintained intrusted_proxies.json).However, for a simple country redirect we don't care if the address is spoofable, so we can use
request.location(which uses#geocoder_spoofable_ipfor the source-IP address) instead.Added a test (
test_redirect_untrusted_proxy) that fails with the old implementation to ensure the updated implementation works as described.