Migration: Add gradeband-based popularity rank columns to Tutorials #19342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlory
approved these changes
Nov 21, 2017
tanyaparker
approved these changes
Nov 21, 2017
|
How is this ever going to pass circle if the columns can't be null, nor can they have info from a gsheet yet? |
|
I think my prior description was misleading, but it's fine to add new values to the gsheet, and in fact that will allow the migration to pass the circle test. |
breville
deleted the
migrate-hoc-tutorials-add-popularity-rank-columns
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gsheet will need valid values before we run this migration, and the migration will need to have made it to production before any code that consumes those values arrives.