Add regional partner workshops lookup APIs needed by the teacher application #19356
Conversation
| @@ -15,4 +15,6 @@ | |||
| class RegionalPartnerProgramManager < ActiveRecord::Base | |||
| belongs_to :program_manager, class_name: 'User' | |||
| belongs_to :regional_partner | |||
|
|
|||
| has_many :pd_workshops, class_name: 'Pd::Workshop', through: :program_manager | |||
There was a problem hiding this comment.
Is this going to return the list of workshops a user is attending, organizing, facilitating?
There was a problem hiding this comment.
Pd::Workshop has a regional_partner, maybe go through that?
There was a problem hiding this comment.
Organizing, via this association on User. Perhaps, instead of pd_workshops, we should call it something like `pd_workshops_organizing ?
That is not set for newly created workshops. AFAIK we had a one time migration to populate it, and it's otherwise it's a placeholder for a future feature - where the UI will (eventually) give partner organizers the choice of organizing a workshop as themselves or as the partner (which could then be shared with other program managers for the same partner).
| @partner_organizer = create :workshop_organizer, :as_regional_partner_program_manager | ||
| @non_partner_organizer = create :workshop_organizer | ||
|
|
||
| @partner_csd_workshop = create :pd_workshop, organizer: @partner_organizer, |
There was a problem hiding this comment.
You can probably DRY this
@partner_cds_workshop, @partner_csp_workshop, etc.. = ['csd', 'csp'].map do |course|
[@partner, @non_partner].map do |partner|
create :pd_workshop, organizer: partner, course: course
end
end.flatten
| # @param [String|Symbol] name - full state name, e.g. "Washington" | ||
| # @param [Boolean] include_dc - (default: false) Whether to include Washington DC as a state. | ||
| # @returns [String] state abbreviation, or nil | ||
| def get_us_state_abbr_from_name(name, include_dc = false) |
There was a problem hiding this comment.
Would we ever want to exclude DC?
There was a problem hiding this comment.
Not that I know of, but the inverse method had that option so I added it for consistency
| end | ||
|
|
||
| def test_get_us_state_abbr_from_name_washington_dc | ||
| assert_nil get_us_state_abbr_from_name(:washington_dc) |
There was a problem hiding this comment.
You can also DRY this with nested loops - up to you if you want to do it
There was a problem hiding this comment.
I stuck with the existing pattern from the rest of this test, and I'd rather not invest more time there now
dashboard/app/models/pd/workshop.rb
Outdated
| @@ -315,6 +315,8 @@ def self.should_have_ended | |||
| in_state(STATE_IN_PROGRESS).scheduled_end_on_or_before(Time.zone.now - 2.days) | |||
| end | |||
|
|
|||
| scope :organized_by_regional_partners, -> {joins(organizer: :regional_partner_program_managers)} | |||
There was a problem hiding this comment.
just realized this isn't used. I ended up joining a different way. I'll remove it and the associated test.
…plication-support-apis
…plication-support-apis
aoby
force-pushed
the
pd-teacher-application-support-apis
branch
from
89b854d
to
24d0e75
Compare
No description provided.