Home & Teacher home: show "HOC is coming" until actual HOC #19403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the homepage's call-to-action and teacher homepage's special announcement, the celebrity content was intended to coincide with "actual-hoc", but launched a week earlier. This change updates each so that the relevant headings say "HOC is coming" until the the Hour of Code actually begins.
joshlory
reviewed
Nov 27, 2017
|
|
||
| {hocLaunch && | ||
| hocLaunch.special_announcement && | ||
| hocLaunch.special_announcement === "celebs2017actualhoc" && |
There was a problem hiding this comment.
Should this be a separate PR? It seems like we should hotfix the "Hour of Code is here" change below, then push the announcement update as part of the normal DTP.
There was a problem hiding this comment.
Turns out that neither needs a hotfix, so we can just send them both out together as part of normal DTP.
|
war approved 11/27. |
Erin007
approved these changes
Nov 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the homepage's call-to-action and teacher homepage's special announcement, the celebrity content was intended to coincide with "actual-hoc", but launched a week earlier. This change updates each so that the relevant headings say "HOC is coming" until the the Hour of Code actually begins.
For the homepage, the "HOC is coming" will change to "HOC is here" when this flag is flipped (from
soon-hoc):DCDO.set("hoc_mode", "actual-hoc")For the teacher homepage special announcement, the "HOC is coming" will change to "HOC is here" when this flag is flipped (from
celebs2017):DCDO.set("hoc_launch", {"special_announcement"=>"celebs2017actualhoc"})current
when flags flipped