New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hoc_mode
DCDO checks
#19408
Fix hoc_mode
DCDO checks
#19408
Conversation
description = I18n.t(:csedweek_og_description_soon) if DCDO.get('soon-hoc', false) | ||
description = I18n.t(:csedweek_og_description_here) if DCDO.get('actual-hoc', false) | ||
description = I18n.t(:csedweek_og_description_soon) if mode == 'soon-hoc' | ||
description = I18n.t(:csedweek_og_description_here) if mode = 'actual-hoc' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing =
?
|
||
title = I18n.t(:csedweek_og_title) | ||
title = I18n.t(:og_title_here) if DCDO.get('actual-hoc', false) | ||
title = I18n.t(:og_title_here) if mode = 'actual-hoc' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing =
?
title = I18n.t(:og_title_soon) if DCDO.get('soon-hoc', false) | ||
title = I18n.t(:og_title_here) if DCDO.get('actual-hoc', false) | ||
title = I18n.t(:og_title_soon) if mode = 'soon-hoc' | ||
title = I18n.t(:og_title_here) if mode = 'actual-hoc' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing =
s?
9b9e85c
to
18602d2
Compare
Confirmed with @boatmarina that this can ship for today, 11/27. |
Fix for PR #19398.
I had written and tested with
DCDO.get('soon-hoc', false)
everywhere, but the actual flag isDCDO.get('hoc_mode', nil)
.