Remove HOC 2017 specific content on homepage, /learn & teacher home #19522
Conversation
| @@ -42,7 +39,7 @@ export default class TeacherHomepage extends Component { | |||
|
|
|||
| render() { | |||
| const { courses, topCourse, announcements, isRtl, queryStringOpen, joinedSections } = this.props; | |||
| const { canViewAdvancedTools, hocLaunch, isEnglish } = this.props; | |||
There was a problem hiding this comment.
If you don't need isEnglish here, do you still need it in PropTypes?
There was a problem hiding this comment.
I deliberately left it there because it was plumbed through and seemed like it might be useful again in the future, but you're right that we're not using it right now.
There was a problem hiding this comment.
My preference would be to remove these when they're no longer used. If we added this back in the future ideally it would be connected via Redux.
| @@ -130,8 +62,6 @@ | |||
| - elsif rack_env != :production && request.params["lock-hero"] | |||
| -# for UI tests just lock to the first hero image | |||
| - heroes_arranged = heroes[0, 1] | |||
| - elsif show_hoc_launch_layout | |||
| - heroes_arranged = hoc_launch_hero[hoc_launch_hero_variation] | |||
| - elsif show_census_layout | |||
There was a problem hiding this comment.
The idea is that we don't know what the homepage takeover will be for next year so we should gut anything related to hoc? Just confirming there isn't anything reusable.
There was a problem hiding this comment.
That was my thinking. I think we could generalise this technique going forward, but it should probably be done in conjunction with a rethink about the gsheet-driven approach for driving the homepage in general.
|
Creating a 2018 hoc doc. 📷 ? Or is this just code cleanup and actual changes of the homepage will come later? |
|
📷 added |
|
After teacher home image is a repeat? |
|
Oops, fixed. |
Conflicts: apps/src/templates/studioHomepages/TeacherHomepage.jsx
before
home
/learn
teacher home
after
home
/learn
teacher home