Testing: Shared test task handles db dependencies better #19537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's fairly common to try running shared tests in development and have them fail because the pegasus test database hasn't run recent migrations. This makes the shared test task depend on running migrations and incremental seeding for the pegasus test database, which makes it a little slower, but is a few less things devs need to memorize to run shared tests reliably.
wjordan
approved these changes
Jan 2, 2018
| with_rack_env(:test) do | ||
| Dir.chdir(pegasus_dir) do | ||
| puts 'Migrating pegasus test database...' | ||
| RakeUtils.rake 'db:ensure_created', 'db:migrate', 'seed:migrate' |
There was a problem hiding this comment.
I wonder if invoking these Rake tasks from within the existing process (using Rake::Task['db:ensure_created'].invoke rather than RakeUtils.rake) would make this preparation run any quicker.
There was a problem hiding this comment.
The replacement you suggested here doesn't work out of the box, because it can't find the db:ensure_created task. I think that's because we're in shared/rake/test.rake but we're trying to run tasks in pegasus/rake/db.rake (hence the directory change). Do you know if there's a clean way to make those pegasus tasks available without exposing them all as part of this rakefile?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's fairly common to try running shared tests in development and have them fail because the pegasus test database hasn't run recent migrations. This makes the shared test task depend on running migrations and incremental seeding for the pegasus test database, which makes it a little slower, but is a few less things devs need to memorize to run shared tests reliably.