Reset S3-client object after each test #19553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cached S3-client objects contain AWS credentials, so reset them to ensure that they are not reused across tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression in test-creation caused by #18812.
Now that S3-client objects (containing AWS credentials) are cached in class variables, we need to explicitly reset them in order to ensure that they are not reused across tests.
This fixes a regression in recording new tests (or re-recording an existing test), when a cached S3-client is populated with test credentials (by a pre-recorded test), then a subsequent test requires actual credentials (for a not-yet-recorded test).