Pre dialog #19558
Merged
Pre dialog #19558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bjvanminnen
force-pushed
the
preDialog
branch
from
2ddf07c
to
7bddb72
Compare
Bjvanminnen
commented
Dec 11, 2017
| ); | ||
| ContractMatchErrorDialog.propTypes = { | ||
| text: PropTypes.string | ||
| }; |
There was a problem hiding this comment.
I've gone back and forth on whether it makes sense to have all of these defined in one place vs. defining each closer to where they are used. The reason I've been going with all in one place is that they are all pretty similar, and this makes this a lot clearer, and I think the long-term fix here should be to have a single React component for all of these (that doesn't use LegacyDialog).
Bjvanminnen
force-pushed
the
preDialog
branch
from
447eed6
to
575d835
Compare
islemaster
approved these changes
Dec 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts moving more LegacyDialogs to have React based contents instead of haml.
One could argue that we should instead take the time to just move these away from using LegacyDialog (which is still a pretty weird mishmash of React and jquery). However, that's (a) going to be a bigger change and (b) I think going to be easier by first moving the content to React.
Of the dialogs moved here, the "pre" dialog is the most interesting one. It was previously the case that you could, in LB, define a title/instructions/anigif for this dialog. This dialog was used in exactly 3 levels (plus 1 allthethingslevel), and was identical in every case. I then hardcoded the dialog, and made it so that
pre_titleis the only field we look at.