Add unit tests for teacher application secion 4: workshops selection #19590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoby
force-pushed
the
pd-teacher-application-unit-tests
branch
from
19a5b90
to
20d66d1
Compare
mehalshah
approved these changes
Dec 12, 2017
| @@ -183,8 +184,8 @@ export default class Section4SummerWorkshop extends ApplicationFormComponent { | |||
| return ( | |||
| <div> | |||
| <h5> | |||
| Your region’s assigned summer workshop will be | |||
| {' ' + this.state.partnerWorkshops[0].dates + ' '} in | |||
| Your region’s assigned summer workshop will be | |||
There was a problem hiding this comment.
Intentional? Are you trying to indent this paragraph?
There was a problem hiding this comment.
unintentional. will fix
| @@ -183,8 +184,8 @@ export default class Section4SummerWorkshop extends ApplicationFormComponent { | |||
| return ( | |||
| <div> | |||
| <h5> | |||
| Your region’s assigned summer workshop will be | |||
| {' ' + this.state.partnerWorkshops[0].dates + ' '} in | |||
| Your region’s assigned summer workshop will be | |||
There was a problem hiding this comment.
Prefer using string interpolation for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bit of complex logic in section 4 of the teacher application: loading assigned workshops via API based on school & course, then sometimes additionally loading alternate workshops. This adds unit tests for that logic.