Discount code bugs #19593
Merged
Discount code bugs #19593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bjvanminnen
force-pushed
the
discountCodeBugs
branch
from
e4a2ee2
to
563d18a
Compare
epeach
approved these changes
Dec 12, 2017
| @@ -144,11 +153,11 @@ export default class EligibilityChecklist extends Component { | |||
| According to our data, your school has fewer than 50% of students that are | |||
| eligible for free/reduced-price lunches. This means that we can bring down | |||
| the cost of the $325 kit to just $97.50.{" "} | |||
| <b> | |||
There was a problem hiding this comment.
I agree with removing {b} but would it be possible to use {strong} rather than {div} here? Screenreaders are able to emphasize the strong tag, so it become perceivable by folks using screenreaders.
There was a problem hiding this comment.
fwiw, the reason i removed the b is because for whatever reason, just bolding gotham 4r seemed to show very little difference in bold. i saw that we use gotham 7r where we want bold elsewhere, so switched to that.
will add a strong. thx for the pointer :)
| @@ -129,7 +133,7 @@ export default class EligibilityConfirmDialog extends Component { | |||
| <label> | |||
| <div>{i18n.verifySignature()}</div> | |||
| <div style={styles.signature}> | |||
| <b>Electronic Signature</b> {i18n.typeName()} | |||
islemaster
approved these changes
Dec 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bunch of small bugs we discovered while walking through the discount code flow on staging-next.
fullDiscountfor some reason when passing to instructionsonClickwas still fired. This fixes that.