Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTP (Test > Production: fce9d98c) #19597

Merged
merged 605 commits into from
Dec 12, 2017
Merged

DTP (Test > Production: fce9d98c) #19597

merged 605 commits into from
Dec 12, 2017

Conversation

caleybrock
Copy link
Contributor

No description provided.

Bjvanminnen and others added 30 commits December 6, 2017 15:58
Create reusable school info input component
…t_fit_images

fix crash in IE related to object-fit-images polyfill
Add Steph Curry video to our website
update mc tile on our site with new image and description
Fixes violations of rubocop Security/JSONLoad.
The resize bar tests pass in isolation but fail when run in the context of our full suite.  This is because testing the resize bar involves firing some events on window, and in lots of other places in our tests we set up singletons like StudioApp that listen to these events and don't get cleaned up properly.

Tracking down all the places StudioApp global is used is going to be prohibitively difficult, and I do actually want the component to fire events in unit tests since it's pretty core functionality.  So for now I'm making the places breaking in response to this a little more resilient when they're called at an odd time.
deploy-code-org and others added 28 commits December 11, 2017 22:39
DTT (Staging > Test) [robo-dtt]
only show Add/Publish in Minecraft when signed in
Stop playing sounds when exiting dialog
Add basic eyes test for submitting a teacher application
ES6+Test MiniView and MiniViewTopRow, with Storybook improvements
DTT (Staging > Test) [robo-dtt]
Make sure all relevant fields are queried on school info deduping
Don't override global `appOptions` in multi levels with embedded blocks
…weaks

Add regional partner link and change 'development' to 'learning'
DTT (Staging > Test) [robo-dtt]
@caleybrock caleybrock merged commit e095cc9 into production Dec 12, 2017
@deploy-code-org deploy-code-org deleted the dtp_candidate_fce9d98c branch December 12, 2017 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet