Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change instance type back after HOC #19598

Merged
merged 1 commit into from
Dec 12, 2017
Merged

Conversation

jeremydstone
Copy link

This changes our production front end instance type from r4.8xlarge (higher memory instance type we were running during hour of code) to m4.10xlarge, the less expensive instance type we normally run.

Copy link
Contributor

@wjordan wjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instance-type change LGTM.

I had made some changes in #19379 that might make this change not longer be applied without an extra manual tweak to an existing parameter. I'll keep an eye out to make sure this change gets applied correctly when it's deployed.

@jeremydstone jeremydstone merged commit 701887a into staging Dec 12, 2017
@jeremydstone jeremydstone deleted the change_instance_type branch December 12, 2017 22:59
@wjordan
Copy link
Contributor

wjordan commented Dec 13, 2017

I've applied the necessary manual tweak to the InstanceType parameter in the production config, so the instance type will be changed on the next production deploy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants