Move isRtl from props to Redux for PersonalRecentProjects

[joshlory]

Continue isRtl Redux cleanup.

[davidsbailey]

Thank you for converting these components into classes!

[davidsbailey]

onSelectApp and viewAllProjects do not appear to be properly bound to this here. I believe the preferred syntax is:

  onSelectApp = appType => {
    this.setState({showAll: false, showApp: appType});
  }

@islemaster has done a bunch of these conversions and may be able to offer a second opinion. Here is one very long explanation, or you can skip to the end: http://reactkungfu.com/2015/07/why-and-how-to-bind-methods-in-your-react-component-classes/

[joshlory]

Right, good catch! I will fix.

[caleybrock]

So does this require a parent of https://github.com/code-dot-org/code-dot-org/blob/staging/apps/src/templates/projects/ProjectWidgetWithData.jsx to be connected? Is that currently always true?

[joshlory]

It does. All three usages of <ProjectWidgetWithData> are connected: TeacherHomepage.jsx, StudentHomepage.jsx, & StageExtras.js.

[joshlory]

@davidsbailey verified fixed (green-red-green) with a shiny new unit test!

[davidsbailey]

Thanks for adding these tests! LGTM