Remove Irish downloads from tutorial downloads #19624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erin007
approved these changes
Dec 13, 2017
|
These are the 2015 tutorials we did as a one-off and it would be a lot of work to revisit. At the moment we don't have plans to try to rebuild the Irish tutorial. |
tanyaparker
approved these changes
Dec 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes Irish download links from our tutorial pages at https://studio.code.org/download/mc and https://studio.code.org/download/starwars. We discovered that the Irish language binaries are actually in Arabic. This was likely some problem with the script at the time we built the tutorial downloads. Since this was a one-time process to build these offline tutorials and to resuscitate and repeat it would take a significant amount of time, we are going to remove the Irish binary from the download list. As far as we know all the other binaries are in their advertised language. (Although I have only done spot checks; I have not tested the full matrix of all languages x 3 tutorials.)