New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix FilesApi.getFiles() to match signature of AssetsApi.getFiles() #19627

Merged

cpirich merged 2 commits into staging from weblab_fix_getFiles_signature_variation

Dec 13, 2017

Contributor

cpirich commented Dec 13, 2017 •

edited

fix signature issue when adding optional version param to the getFiles() API (introduced in Fix weblab version history #19329). The assets manager can use either FilesApi or AssetsApi - we need to keep the signatures compatible.


          fix FilesApi.getFiles() to match signature of AssetsApi.getFiles()

5a5b27a

cpirich requested a review from islemaster

December 13, 2017 17:51


          Add version to param to other getFiles() API to ensure consistency

e4a924c

islemaster approved these changes

View reviewed changes

Contributor

islemaster commented Dec 13, 2017

Verified locally that Web Lab asset dialog works with this change.

cpirich merged commit c486f61 into staging

cpirich deleted the weblab_fix_getFiles_signature_variation branch

December 13, 2017 19:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment