Regional partner dropdown default #19647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clareconstantine
force-pushed
the
regional-partner-dropdown-default
branch
from
3528d9c
to
55a681b
Compare
aoby
approved these changes
Dec 14, 2017
| rows = rows.filter(row => row.regional_partner_id === this.props.regionalPartnerFilter); | ||
| } else { | ||
| rows = rows.filter(row => row.regional_partner_id === null); |
There was a problem hiding this comment.
nit: reorder with the positive case first, i.e. this.props.regionalPartnerFilter === UnmatchedFilter
clareconstantine
force-pushed
the
regional-partner-dropdown-default
branch
from
9500928
to
78f96c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When viewing the application dashboard as a workshop admin, the summary and list views default to showing only unmatched applications.
cc @tanyaparker