DTP (Test > Production: 15ece2f1) #19673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Embedding the status select in an InputGroup causes it in chrome to extend to the full width of the page, but in firefox it stays the same size. It's not clear to me why this is happening, but a simple maxWidth on the element will keep it looking nice while I investigate, and unblock those who are blocked by the current state of the form
DTL (Test > Levelbuilder: 9f0d92c)
Hoist the onclick handler from the span to the parent button.
We still get production jQuery from the `jquery-rails` gem, which is locked at version 4.1.1, which corresponds to jQuery 1.12.1 according to [this documentation](https://github.com/rails/jquery-rails/blob/master/VERSIONS.md). Our apps tests use jQuery from an npm package, and were using version 2.1.4. This changes them to use a jQuery version consistent with our release build.
Lock npm jQuery dependency to 1.12.1
…firefox Homepage: fix video popup on Firefox
…rome Fix Application Status select width in Chrome
DTT (Staging > Test) [robo-dtt]
DTS (Levelbuilder > Staging) [robo-dts]
…-weblab-correct-share-links Web Lab: Correct share links in different environments
…count-email-in-csv Add user account email in the teacher application csv download
New Finish Dialog
DTT (Staging > Test) [robo-dtt]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.