Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join block inputcount wildcard validation #19686

Merged
merged 3 commits into from Jan 2, 2018
Merged

Conversation

balderdash
Copy link
Contributor

This PR allows you to set the inputcount of a join block to ???, which matches it against any use of a join block when used in required blocks. When the inputcount is set to ???, we also skip any validation on the children of the join block.

This also brings back validation of the inputcount attribute when it's set to anything other than ???.

Copy link
Contributor

@joshlory joshlory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great test coverage!

@balderdash balderdash merged commit 47644d9 into staging Jan 2, 2018
@balderdash balderdash deleted the join-block-verification branch January 10, 2018 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants