Remove sync-apps script #19714
Merged
Remove sync-apps script #19714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to #19445 Now that apps translation files are automatically built with english fallback, it's no longer necessary to explicitly propagate newly-added i18n strings out to every locale. Note that because it used to be the case that this required sync only happened on a staging build, circle tests were formerly unable test i18n. Therefore, next steps are to identify tests that have been flagged with no-circle but no longer need to be.
Bjvanminnen
approved these changes
Jan 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #19445
Now that apps translation files are automatically built with english
fallback, it's no longer necessary to explicitly propagate newly-added
i18n strings out to every locale.
Note that because it used to be the case that this required sync only
happened on a staging build, circle tests were formerly unable test
i18n. Therefore, next steps are to identify tests that have been flagged
with no-circle but no longer need to be.