In cohort view, add columns for assigned workshop/fit #19727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoby
approved these changes
Jan 4, 2018
| @@ -105,6 +106,10 @@ def set_type_and_year | |||
| self.application_type = nil | |||
| end | |||
|
|
|||
| def update_accepted_date | |||
| self.accepted_at = status == 'accepted' ? Time.now : nil | |||
| end | |||
There was a problem hiding this comment.
how about, above on line 100
before_save :update_accepted_date, if: -> {status_changed? && accepted?}Then this method can be simplified to:
def update_accepted_data
self.accepted_at = Time.zone.now
endThere was a problem hiding this comment.
I want accepted date to be cleared if the application is un-accepted
|
|
||
| test 'accepted_at updates times' do | ||
| time_1 = Date.today.to_time | ||
| time_2 = Date.tomorrow.to_time |
There was a problem hiding this comment.
nit: how about today and tomorrow instead of time_1 and time_2 for clarity?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Left some parts unimplemented for the time being