Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header: remove CSS that was only used for legacy header #19729

Merged
merged 2 commits into from Jan 4, 2018
Merged

Header: remove CSS that was only used for legacy header #19729

merged 2 commits into from Jan 4, 2018

Conversation

breville
Copy link
Member

@breville breville commented Jan 3, 2018

And rename header2* to header* now that we have fully switched to the new header.

@breville breville requested a review from Erin007 January 3, 2018 00:07
Erin007
Erin007 approved these changes Jan 3, 2018
View reviewed changes
Copy link
Contributor

@Erin007 Erin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code changes look good. Let's double check everything once this hits staging: dashboard & pegasus, mobile & desktop, LTR & RTL (and all the combos) just to be sure.

@breville breville merged commit 43d0e97 into staging Jan 4, 2018
@breville breville deleted the remove-unused-legacy-header-css branch January 4, 2018 04:14
@breville breville mentioned this pull request Jan 4, 2018
Merged
@breville breville requested a review from joshlory January 6, 2018 00:01
This was referenced Jan 6, 2018
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erin007 Erin007 Erin007 approved these changes

@joshlory joshlory Awaiting requested review from joshlory

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@breville @Erin007