Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created block for colorLeds[i].pulse #19737

Merged
merged 4 commits into from Jan 12, 2018
Merged

Created block for colorLeds[i].pulse #19737

merged 4 commits into from Jan 12, 2018

Conversation

MeyAyre
Copy link
Contributor

@MeyAyre MeyAyre commented Jan 3, 2018

Added this ability to the johnny-five RGB component in code-dot-org/johnny-five#10. This PR updates the johnny-five version to one with the new feature, and adds maker blocks so it's available to students and levelbuilders.

Click to watch on YouTube

@islemaster islemaster self-assigned this Jan 9, 2018
@islemaster islemaster force-pushed the colorleds-pulse branch 2 times, most recently from 2bce371 to 6ad66f9 Compare January 11, 2018 23:06
Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulse looks really nice in the video!

Would we want to add this to sharedApplabBlocks.js ? I see most other maker commands there, and my reading of

* This is the default set of functions available to us if the levelbuilder
* leaves codeFunctions blank.
* They are defined in Applab.rb, and generated into a static JS file via
* generateSharedConstants.rb
*/
'codeFunctions': ApplabBlocks
is that this would be needed to make this block available to levelbuilders.

LGTM after considering adding to sharedApplabBlocks.js.

@islemaster
Copy link
Contributor

Including this block in shared_constants.rb is sufficient; from the top of sharedApplabBlocks.js:

// This is a generated file and SHOULD NOT BE EDITTED MANUALLY!!
// Contents are generated as part of grunt build
// Source of truth is lib/cdo/shared_constants.rb

@davidsbailey
Copy link
Member

Ah right, plus sharedApplabBlocks.js is not even in our repo. sounds good :-)

@islemaster islemaster merged commit deeaca2 into staging Jan 12, 2018
@islemaster islemaster deleted the colorleds-pulse branch January 12, 2018 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants