Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed default value for onBoardEvent block #19743

Merged
merged 1 commit into from Jan 4, 2018
Merged

Changed default value for onBoardEvent block #19743

merged 1 commit into from Jan 4, 2018

Conversation

MeyAyre
Copy link
Contributor

@MeyAyre MeyAyre commented Jan 3, 2018

Before:
image

After:
image

@caleybrock
Copy link
Contributor

code change lgtm, but @islemaster would have more context on if this makes sense.

islemaster
islemaster approved these changes Jan 3, 2018
View reviewed changes
Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, "press" is no longer in the dropdown for button events.

@MeyAyre MeyAyre merged commit ca3c3b0 into staging Jan 4, 2018
@balderdash balderdash deleted the onboardevent-dropdown-default branch September 20, 2018 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islemaster islemaster islemaster approved these changes

@caleybrock caleybrock Awaiting requested review from caleybrock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MeyAyre @caleybrock @islemaster