Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor QuickActionsCell and SectionActionDropdown #19760

Merged
merged 3 commits into from Jan 4, 2018
Merged

Refactor QuickActionsCell and SectionActionDropdown #19760

merged 3 commits into from Jan 4, 2018

Conversation

caleybrock
Copy link
Contributor

@caleybrock caleybrock commented Jan 4, 2018 •
edited

No new functionality in this PR, just refactoring.

  • Update QuickActionsCell to use PopUpMenu: QuickActions didn't pass actions through, and PopUpMenu is used in the SectionActionDropdown and in the SettingsCog.
  • Update SectionActionDropdown to use QuickActionsCell

@caleybrock caleybrock requested a review from epeach January 4, 2018 21:22
@caleybrock caleybrock changed the title Use PopUpMenu in QuickActionsCell Refactor QuickActionsCell and SectionActionDropdown Jan 4, 2018
@caleybrock
Copy link
Contributor Author

I might let circle run UI tests, but the unit tests for SectionActionDropdown still pass 👍

epeach
epeach approved these changes Jan 4, 2018
View reviewed changes
Copy link

@epeach epeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Happy to see this evolution.

@caleybrock caleybrock merged commit 2ee3123 into staging Jan 4, 2018
@caleybrock caleybrock deleted the add-dropdown branch January 4, 2018 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epeach epeach epeach approved these changes

Assignees
No one assigned
Labels
code-hygiene teacher-dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@caleybrock @epeach