start auto-marking successful DTTs green #19787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
force-pushed
the
auto-mark-dtts-green
branch
from
d8b9c6b
to
d08b610
Compare
|
🎉 Hooray! (and I'm not even effected...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19609 and #19679 set up automatically marking successful DTTs green, but the marking mechanism was temporarily disabled while we worked out the kinks in the detection logic. Since the latter of those PRs was merged at 4:38pm on Jan 2, the detection logic has correctly marked 3 DTTs green:
and has correctly NOT marked the remaining failing DTTs green.
Interestingly, in the above instances the commit hash is 1 character shorter when being auto-marked green than it is when being marked green via bin/dotd script, e.g.
b50bf9einstead ofb50bf9ee. This shorter hash is coming from thegit rev-parse --shortcommand being run locally, which is guaranteed to provide a unique commit hash prefix, instead of the utility functionGitHub.sha, which is used to get a fixed-length, 8-character hash prefix from github.