Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary global #19808

Merged
merged 1 commit into from Jan 8, 2018
Merged

remove unnecessary global #19808

merged 1 commit into from Jan 8, 2018

Conversation

Bjvanminnen
Copy link
Contributor

@Bjvanminnen Bjvanminnen commented Jan 5, 2018 •
edited

I can't find any other uses of initLevelGroup in our code base anymore, so there's no reason this should be on window.

caleybrock
caleybrock approved these changes Jan 8, 2018
View reviewed changes
Copy link
Contributor

@caleybrock caleybrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. I did a search too and couldn't find anything.

@Bjvanminnen Bjvanminnen merged commit fa45ea5 into staging Jan 8, 2018
@Bjvanminnen Bjvanminnen deleted the initLevelGroup branch January 8, 2018 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caleybrock caleybrock caleybrock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Bjvanminnen @caleybrock