Log video hint clicks to firehose #19854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 8, 2018 11:38
joshlory
approved these changes
Jan 11, 2018
| @@ -1,5 +1,5 @@ | |||
| import {showVideoDialog} from "@cdo/apps/code-studio/videos"; | |||
| import React, {PropTypes, Component} from 'react'; | |||
| import React, {Component, PropTypes} from 'react'; | |||
| { includeUserId: true } | ||
| ); | ||
| }, | ||
|
|
||
| render() { | ||
| return ( | ||
| <ChatBubble borderColor={this.props.borderColor} ttsUrl={this.props.ttsUrl} ttsMessage={this.props.ttsMessage}> |
There was a problem hiding this comment.
Do we also want to track that the user asked to see the hint? I think this data is already in the DB, but maybe easier to correlate with hint video clicks if we log it to Firehose as well. @bencodeorg any preference?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send video hint clicks to firehose, including user, script, level, and video hint IDs.