Maker: Redesigned setup page #19863
Merged
Maker: Redesigned setup page #19863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
force-pushed
the
maker-setup-page
branch
from
60c4014
to
022e22a
Compare
ewjordan
reviewed
Jan 16, 2018
| stepName="Using a supported browser" | ||
| stepStatus={Status.FAILED} | ||
| > | ||
| {isChrome() && `It looks like your Chrome version is ${getChromeVersion()}.`} |
There was a problem hiding this comment.
Is this necessary? Seems like this could never happen based on the if above
There was a problem hiding this comment.
Good point. I'll tear this out.
ewjordan
reviewed
Jan 16, 2018
| } | ||
|
|
||
| export function isChromeOS() { | ||
| return /\bCrOS\b/.test(navigator.userAgent); |
There was a problem hiding this comment.
I can't believe that's actually the string that ChromeOS uses...gross, but not our gross.
ewjordan
approved these changes
Jan 16, 2018
islemaster
force-pushed
the
maker-setup-page
branch
2 times, most recently
from
e9108cb
to
18944dc
Compare
islemaster
force-pushed
the
maker-setup-page
branch
from
18944dc
to
b0e6dbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redesigns the Maker setup page to display platform-specific information, and to move a lot of the verbose setup details into a support article that we reference if the more automated setup doesn't work.
Spec, support article
Known limitations
Screenshots
Maker Browser on Mac/Linux
Maker Browser on Windows
Chrome OS
Windows (not Maker Toolkit App)
OSX (not Maker Toolkit App)
Unsupported browser view